Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking r/sys/teams work #2957

Closed

Conversation

irreverentsimplicity
Copy link
Contributor

This draft PR is for tracking work on the r/sys/teams package.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.00%. Comparing base (9897b66) to head (41ce128).
Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2957      +/-   ##
==========================================
+ Coverage   60.87%   63.00%   +2.13%     
==========================================
  Files         563      563              
  Lines       75193    80511    +5318     
==========================================
+ Hits        45770    50727    +4957     
- Misses      26055    26390     +335     
- Partials     3368     3394      +26     
Flag Coverage Δ
contribs/gnodev 60.62% <ø> (-0.84%) ⬇️
contribs/gnofaucet 15.77% <ø> (+0.45%) ⬆️
gno.land 67.56% <ø> (+0.38%) ⬆️
gnovm 67.25% <ø> (+1.61%) ⬆️
misc/genstd 79.72% <ø> (-0.83%) ⬇️
misc/logos 19.95% <ø> (-0.28%) ⬇️
tm2 62.25% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul
Copy link
Member

moul commented Oct 20, 2024

Closed #2959.

@moul moul mentioned this pull request Oct 20, 2024
@moul
Copy link
Member

moul commented Oct 20, 2024

Thank you, Dragos, for your efforts. Please read this: #2195 (comment).

You'll see that the current PR is quite far from our expectations.

You may continue with this PR if you want to create a different team system, such as p/demo/team_manager, instead of r/sys/teams. However, I suggest closing this one, as starting from scratch may be easier than trying to improve this version if your goal is r/sys/users.

If you choose to proceed, please review #2195 multiple times. Feel free to ask questions or propose a design plan before you begin implementation. I understand that r/sys/teams may not be straightforward, and it's easy to miss our requirements.

@irreverentsimplicity
Copy link
Contributor Author

Thank you for taking the time to look into this, and for the feedback. I'm closing it as per your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants